Milestone 1.5.1 — Phase 1 Security Integration Test Suite (Cross-Tenant + Auth Boundary Gate)

Status: Complete
Goal: 1.5 — Phase 1 Security Gate
Phase: 1 — Core Platform
Estimated effort: 3–4 days
ADR required: None (test suite, not design decision)

Why This Milestone Exists

This milestone is the explicit completion gate for Phase 1. It exists because individual milestone acceptance criteria only verify their own narrow slice. A system can have all milestones marked complete and still have emergent security failures when the pieces are composed together.

What individual milestone tests cannot catch:

• M1.2.1 tests that auth middleware calls gRPC correctly.
• M1.2.5 tests that agent verification calls auth correctly.
• M1.2.4 tests that rate limiting calls Redis correctly.
• None of them test that the composed middleware chain — auth → agent verification → rate limit → handler — enforces the full security model end-to-end through a real HTTP connection with a real Postgres database and real Redis.

This milestone writes and runs exactly those end-to-end security integration tests. It is the Phase 1 completion certificate.

The security model being validated:

1. Every request without a valid token is rejected before reaching the handler.
2. Every request with a valid token for Org A cannot access resources belonging to Org B.
3. Revoked tokens are rejected within the documented SLA.
4. Agents belonging to a different org are rejected, even with a valid token.
5. Rate limits are enforced per org and return correct headers.
6. Permission bitmap enforcement rejects insufficient permissions.

Non-Goals

• Performance or load testing (covered in Phase 2 milestone 2.6.1)
• Fuzzing or penetration testing (out of scope for Phase 1)
• Testing Phase 2+ functionality (LLM forwarding, directive injection)

Branch

test/m1-5-1-security-integration-test-suite

PR Title

test(security): Phase 1 security integration test suite — Phase 1 gate (m1.5.1)

Prerequisites

All of the following must be merged before this milestone begins:

• 1.1.7 — users + agents tables
• 1.2.4 — rate limiting middleware
• 1.2.5 — agent identity verification
• 1.2.6 — request ID middleware
• 1.4.1 — seed data and compose-test stack

Test Matrix

Category 1: Token Authentication

Category 2: Agent Identity Verification

Category 3: Cross-Tenant Isolation via Proxy

Category 4: Rate Limiting

Category 5: Permission Bitmap Enforcement

Category 6: Response Headers and Envelope Consistency

Test Infrastructure

//go:build integration
 
// Test infrastructure pattern for security tests:
// Each test creates its own orgs and data and runs in isolation.
 
type securityTestEnv struct {
    proxy    *httptest.Server  // proxy under test (real middleware chain)
    auth     *grpc.Server      // real auth gRPC service
    postgres *pgxpool.Pool     // test Postgres via testcontainers
    redis    *miniredis.Miniredis
}
 
// setupTwoOrgs creates two isolated orgs with agents and tokens.
// All data is cleaned up by t.Cleanup.
func setupTwoOrgs(t *testing.T, env *securityTestEnv) (orgA, orgB testOrgContext)
 
type testOrgContext struct {
    OrgID   uuid.UUID
    AgentID uuid.UUID
    Token   string // raw PAT
}

Acceptance Criteria

• All 35+ test cases in the matrix above pass with -tags=integration
• SEC-3.4: p95 timing delta between cross-org denials < 50ms in CI
• SEC-4.5: rate limits are per-org (Org B not affected by Org A's exhaustion)
• All error responses pass SEC-6.x schema checks
• Test suite runs in < 60 seconds in CI
• CI gate security-integration added to required checks on main branch
• docs/SECURITY.md updated with the security model that this suite validates

Risks